CMake: Increase CMake minimum version to 3.29#88609
Draft
Steelskin wants to merge 1 commit into
Draft
Conversation
CMake 3.29 introduces CMP0157, which improves Swift support in CMake. These changes require swiftlang/swift-syntax#3321 to work properly as swift-syntax does not build with CMP0157 set to NEW otherwise.
Contributor
Author
|
@swift-ci please test windows platform |
Contributor
Author
|
Please test with following PRs: @swift-ci please build toolchain Windows platform |
Member
|
CC: @etcwilde |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CMake 3.29 introduces CMP0157, which improves Swift support in CMake.
These changes require swiftlang/swift-syntax#3321 to work properly as swift-syntax does not build with CMP0157 set to NEW otherwise.
The built artifacts should be identical with these changes.
Minimal. The changes were tested locally and will be tested on CI.
Local testing + CI.