Skip to content

[Observations] Prevent duplicate emissions on re-iterating Observations after cancellation #86145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Jiaxu-Li wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −3
Open

[Observations] Prevent duplicate emissions on re-iterating Observations after cancellation #86145

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions stdlib/public/Observation/Sources/Observation/Observations.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,6 @@ public struct Observations<Element: Sendable, Failure: Error>: AsyncSequence, Se
// internal funnel method for initialziation
internal init(emit: Emit) {
self.emit = emit
self.state = _ManagedCriticalState(State())
}

/// Constructs an asynchronous sequence for a given closure by tracking changes of `@Observable` types.
Expand Down Expand Up @@ -167,7 +166,6 @@ public struct Observations<Element: Sendable, Failure: Error>: AsyncSequence, Se
// the state ivar serves two purposes:
// 1) to store a critical region of state of the mutations
// 2) to idenitify the termination of _this_ sequence
var state: _ManagedCriticalState<State>?
let emit: Emit
var started = false

Expand Down Expand Up @@ -251,6 +249,6 @@ public struct Observations<Element: Sendable, Failure: Error>: AsyncSequence, Se
}

public func makeAsyncIterator() -> Iterator {
Iterator(state: state, emit: emit)
Iterator(state: _ManagedCriticalState(State()), emit: emit)
}
}