[Swiftify] don't attach macro when module does not import stdlib #86138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prevents stuff like memcmp from SwiftShims from being imported with @_SwiftifyImport, which would then result in name lookup errors as it does not import the Swift standard library module. This makes the previous approach to disable safe interop when compiling with -parse-stdlib redundant. irdar://165856959
hnrklssn
requested review from
DougGregor,
Xazax-hun,
artemcm,
beccadax,
egorzhdan,
ian-twilightcoder,
j-hui,
susmonteiro and
tshortli
as code owners
Member
Author
|
@swift-ci please smoke test |
j-hui
approved these changes
Dec 19, 2025
Xazax-hun
approved these changes
Dec 19, 2025
Member
Author
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents stuff like memcmp from SwiftShims from being imported with @_SwiftifyImport, which would then result in name lookup errors as it does not import the Swift standard library module. This makes the previous approach to disable safe interop when compiling with -parse-stdlib redundant.
rdar://165856959