linux: remove swiftImageInspectionShared

[compnerd]

Merge this into the runtime as expected rather than having a separate
component.

Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.

Resolves SR-NNNN.

[compnerd]

CC: @spevans @bob-wilson @jrose-apple @jckarter

What could go wrong?

[compnerd]

@swift-ci please test Linux platform

[bob-wilson]

I think I have a better solution. At least I understand better what happened to cause this. Let me create a PR....

[bob-wilson]

See #14880

[bob-wilson]

(I'm not opposed to removing the library if that's the right thing to do, but I'd much prefer a more minimal solution for Swift 4.1.)

[compnerd]

@swift-ci please test macOS platform

[swift-ci]

Build failed
Swift Test OS X Platform
Git Sha - 7feea226230a51d247dc41652b509912b7bdd97a

[swift-ci]

Build failed
Swift Test OS X Platform
Git Sha - 7feea226230a51d247dc41652b509912b7bdd97a

[compnerd]

@swift-ci please test macOS platform

[bob-wilson]

Even if this is the right thing to do, can you please hold off merging it until after we've tested #14880 and confirmed that it fixes SR-7038?

[compnerd]

@bob-wilson sure thing

[compnerd]

@bob-wilson okay with me rebasing/merging this?

[bob-wilson]

Now that we've sorted out SR-7038, I have no objections from a process perspective. On the technical front, I am confused. When we tried to stop linking that library, things broke, right? What is different now?

[compnerd]

The change is merging the provider into the runtime itself. So when the runtime is linked, the dependency is satisfied.

[bob-wilson]

OK, I guess that should be fine then. Someone else who understands this better should review it.

[jrose-apple]

That's probably @jckarter (sorry, @jckarter).

[jckarter]

I haven't been following these changes close enough to comment, sorry. If @compnerd and @spevans think it's OK, they're probably in the best position to say so.

[CodaFi]

@compnerd Could you rebase this so we can get it merged?

[compnerd]

CC: @spevans

@CodaFi necromancing level infinity! :-p

[compnerd]

@swift-ci please test

[swift-ci]

Build failed
Swift Test Linux Platform
Git Sha - f65d7f4d1e6f038fa7b4abc5196e06dcc183e9de

[compnerd]

@swift-ci please test

[swift-ci]

Build failed
Swift Test OS X Platform
Git Sha - fdf1c35

[swift-ci]

Build failed
Swift Test Linux Platform
Git Sha - fdf1c35

[compnerd]

@swift-ci please clean test

[swift-ci]

Build failed
Swift Test OS X Platform
Git Sha - fdf1c35

[compnerd]

@swift-ci please test macOS platform

[CodaFi]

Cool!

[spevans]

The reason for have ImageInspectionShared and ImageInspectionStatic is that there are two versions of lookupSymbol that need to be linked in:

The version in ImageInspectionShared uses dladdr() and is used to support -static-stdlib . The other version in ImageInspectionStatic uses its own implementaion to parse a static ELF binary when used with -static-executable. This is used by #29039

[compnerd]

I think that it makes sense to remove lookupSymbol from SwiftRT-ELF.cpp. That file is meant for the metadata introspection. It would make sense for that code-movement to be part of #29039 I think.

[shahmishal]

Please update the base branch to main by Oct 5th otherwise the pull request will be closed automatically.

• How to change the base branch: (Link)
• More detail about the branch update: (Link)

[spevans]

@compnerd I have done an updated version of this PR in #34180

[compnerd]

Great, I'll close this off then.