Skip to content

Enable Android emulator testing with the snapshot toolchains employing swift-build in SwiftPM #1745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
finagolfin wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −1
Open

Enable Android emulator testing with the snapshot toolchains employing swift-build in SwiftPM #1745

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/pull_request.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ jobs:
ls -ld /Applications/*Xcode*
tests:
name: Test
uses: swiftlang/github-workflows/.github/workflows/swift_package_test.yml@0.0.11
uses: swiftlang/github-workflows/.github/workflows/swift_package_test.yml@main

@harlanhaskins harlanhaskins Jun 5, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shahmishal Should we cut a new tag of swift_package_test? I would rather we not depend on main here, but the last tag was April 14th

@finagolfin finagolfin Jun 5, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hold on, we're still adjusting the Android workflow to swift-build, swiftlang/github-workflows#277 and the NDK bug below, for which this repo is a good test.

@stmontgomery stmontgomery Jun 10, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just echoing @harlanhaskins: I think we should not switch to main, and should instead wait for a new tag of github-workflows containing whatever new content you need. We use pinned versions intentionally.

@finagolfin finagolfin Jun 10, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, but I can't test those new workflow changes from upstream without this update of the workflow branch here, while I work on this pull and the workflow changes needed.

@stmontgomery stmontgomery Jun 10, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Absolutely, no problem. I only meant to say that I think by the time this lands, we ought to replace this with a new tag. Using it temporarily to iterate makes sense

with:
linux_swift_versions: '["nightly-main", "nightly-6.3"]'
linux_os_versions: '["amazonlinux2", "jammy"]'
Expand All @@ -36,6 +36,7 @@ jobs:
enable_android_sdk_build: true
android_ndk_versions: '["r28c", "r29"]'
android_sdk_triples: '["aarch64-unknown-linux-android33", "x86_64-unknown-linux-android28"]'
enable_android_sdk_checks: true
enable_freebsd_checks: true
freebsd_swift_versions: '["nightly-main"]'
freebsd_os_versions: '["14.3"]'
Expand Down
Loading