Skip to content

Sort Windows environment block alphabetically #307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iCharlesHu merged 1 commit into from
Jun 12, 2026
Merged

Sort Windows environment block alphabetically #307

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions Sources/Subprocess/Platforms/Subprocess+Windows.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -988,11 +988,16 @@ extension Configuration {
}
// The environment string must be terminated by a double
// null-terminator. Otherwise, CreateProcess will fail with
// INVALID_PARMETER.
// INVALID_PARMETER. It must also be sorted alphabetically according to
// CreateProcessW's documentation:
// > To do so, the application must explicitly create these environment variable
// > strings, sort them alphabetically (because the system uses a sorted environment),
// > and put them into the environment block.
let environmentString =
env.map {
$0.key.rawValue + "=" + $0.value
}.joined(separator: "\0") + "\0\0"
env
.sorted { $0.key < $1.key }
.map { $0.key.rawValue + "=" + $0.value }
.joined(separator: "\0") + "\0\0"

// Prepare arguments
let (
Expand Down
Loading