Cancel a stalled standard-input writer when the child process exits#306
Merged
Merged
Conversation
jakepetroules
approved these changes
Jun 9, 2026
When run() feeds standard input from a source that can stall and the child process exits before consuming that input, run() could hang indefinitely. The input-writing task was parked awaiting its source rather than blocked inside a pipe write, so the existing cancelAsyncIO path (which only unblocks in-flight pipe I/O) could not release it, and the I/O task group never finished draining. Spawn a waitForProcessTermination waiter alongside the input-writing task that cancels the I/O group once the child exits. Also add edge-case coverage for process I/O and AsyncIO, ported from swift-async-process and swift-nio and replace FileDescriptor.close with _safelyClosed.
ee4615f to
7815dfe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
run()feeds standard input from a source that can stall and the child process exits before consuming that input,run()could hang indefinitely. The input-writing task was parked awaiting its source rather than blocked inside a pipe write, so the existingcancelAsyncIOpath (which only unblocks in-flight pipe I/O) could not release it, and the I/O task group never finished draining. Spawn awaitForProcessTerminationwaiter alongside the input-writing task that cancels the I/O group once the child exits.Also add edge-case coverage for process I/O and AsyncIO, ported from
swift-async-processandswift-nioand replaceFileDescriptor.closewith_safelyClosed.