Allow run body closures to return noncopyable values#305
Merged
Conversation
jakepetroules
approved these changes
Jun 9, 2026
The value a run() body closure returns may now be ~Copyable, so a closure can hand back a move-only resource. ExecutionResult and the internal ExecutionOutcome are now conditionally Copyable/Sendable: copyable exactly when the closure result is, so existing Copyable usages are unaffected Add ExecutionResult.takeClosureResult() as a consuming accessor when closure result is ~Copyable to allow closure result to be moved out Rename closureOutput to closureResult to match the ClosureResult generic parameter and the doc comment
iCharlesHu
force-pushed
the
charles/non-copyable-result
branch
from
1172373 to
aae73aa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The value a run() body closure returns may now be ~Copyable, so a closure can hand back a move-only resource. ExecutionResult and the internal ExecutionOutcome are now conditionally Copyable/Sendable: copyable exactly when the closure result is, so existing Copyable usages are unaffected
Add ExecutionResult.takeClosureResult() as a consuming accessor when closure result is ~Copyable to allow closure result to be moved out
Rename closureOutput to closureResult to match the ClosureResult generic parameter and the doc comment