Add package tests for FoundationEssentials, FoundationInternationalization, and FoundationMacros#149
Merged
jmschonfeld merged 2 commits intoSep 10, 2024
Conversation
…ation, and FoundationMacros
Contributor
Author
|
@swift-ci please test |
parkera
approved these changes
Sep 9, 2024
etcwilde
approved these changes
Sep 10, 2024
Contributor
Author
|
With the latest changes, these tests passed at swiftlang/swift#75321 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The package integration tests already include very small, fundamental tests to ensure that the Foundation libraries in the toolchain can be loaded. Now that Foundation's tests are built and run with SwiftPM, these package integration tests are critical to ensure that the binaries installed into the toolchain are functional (have correct rpaths, are installed to the proper locations, link the appropriate libraries, etc.) since the unit tests will rely on separately built, testable binaries that are not installed. This expands the set of tests within the Foundation package tests to also exercise imports of FoundationEssentials and FoundationInternationalization, as well as ensure that FoundationMacros can be loaded by the compiler. The last piece is the main driver for adding this, since nothing in the toolchain today uses FoundationMacros, so this is important to avoid shipping a broken macro module.