6.4: compare CMAKE_SYSTEM_NAME against string literals#2041
Merged
Conversation
Contributor
Author
|
@swift-ci test |
jmschonfeld
approved these changes
Jun 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation: As part of the bring up of debian13, the platform is using a newer cmake 3.31. cmake 3.31 sets
WASI=1so:evaluates as
"WASI" STREQUAL "1"on cmake 3.31 (which Is false), silently skipping the-D_GNU_SOURCEcompile option for WASI targets. This results induring toolchain builds.
Debian 12 has Cmake 3.25 which has no WASI variable, so WASI fell through to a literal string and the condition evaluated correctly by comparing against the string literal
Scope: limited to WASI builds;
Risk: low due to limited scope;
Testing: tested in local builds and Debian 13 CI.
Issue: rdar://179825652
Reviewer: @jmschonfeld