PropertyListEncoder can create XML documents containing null bytes#2039
Merged
Conversation
Contributor
Author
|
@swift-ci Please test |
parkera
approved these changes
Jun 15, 2026
kperryua
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The XML spec explicitly forbids NUL bytes. We should prevent clients from being able to create XML property lists containing them.
Since this is a restriction of just XML, this prohibition should not apply to binary plists. As annoying as embedded NUL strings are when used without care, I think we're obligated to preserve them in places where they are not forbidden.
Also, in the spirit of "be liberal in what you accept, but strict in what you produce"—and to reduce the potential risk of this change—I'm not proposing any change to XML plist deserialization, which currently DOES accept NUL bytes.