Re-add ContiguousBytes.withBytes protocol requirement#2030
Merged
Conversation
Contributor
Author
|
@swift-ci please test |
itingliu
approved these changes
Jun 10, 2026
Contributor
Author
|
Confirmed that the toolchain now builds successfully and there are no client build failures |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-lands the
withBytesprotocol requirement onContiguousBytesMotivation:
Now that swiftlang/swift#87227 is resolved, we can re-land this change
Modifications:
Uncomments the
withBytesprotocol requirement forContiguousBytesResult:
Now,
ContiguousBytesconformers can override the default implementation ofwithBytesTesting:
Verified that the build still passes and will confirm that clients build successfully