Prepare Data(capacity:_:) and Data(rawCapacity:_:) for renaming#2029
Merged
jmschonfeld merged 1 commit intoJun 9, 2026
Merged
Conversation
Contributor
Author
|
@swift-ci please test |
glessard
approved these changes
Jun 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Marks
Data's relatively new initializers as non-public while its naming is under reviewMotivation:
I'm preparing a pitch for new APIs across the
Datatype that align with new APIs proposed forUniqueArrayandRigidArray. I'd like to reconsider the naming of these initializers to make them consistent with new naming proposed for other to-be-added APIs. Since we haven't shipped them yet, we can avoid a deprecate-and-replace by hiding the new APIs for now until the naming is confirmedModifications:
Marks the two initializers as
internalor@_spias needed to hide them without breaking clients.Result:
These APIs are not widely accessible until the naming is finalized
Testing:
Existing unit tests still pass