Field utf8span property#1849
Open
kperryua wants to merge 1 commit into
Open
Conversation
…ielding borrow` that manually keeps a non-pointer-representation StaticString UTF8Span alive
Contributor
Author
|
This construction worked on an older toolchain, but simply fails with a compiler error on newer toolchains. Has it been defined as invalid somehow, or is it a bug? |
Contributor
Author
|
Update: this still fails on 5/4/26 main toolchain. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Swap
withUTF8Spanforutf8Spanwith a yielding borrow accessor.Motivation:
The
withUTF8SpanAPI onCodingFieldwas an unfortunate accommodation sinceStaticString's could not guarantee an immortal lifetime for non-pointer-representation strings. This was especially unfortunate given how rare these strings are.Modifications:
Use
yielding borrowaccessors to maintain the lifetime of aUTF8Spanso we don't need the closure.Result:
No more unfortunate closures.
Testing:
The
utf8Spanproperty implementation is specified by default implementation onStaticStringCodingField, so any test/benchmark types currently using that will automatically get this.