UUID v7 - Proposal, implementation, and performance enhancements#1836
Open
parkera wants to merge 16 commits into
Open
UUID v7 - Proposal, implementation, and performance enhancements#1836parkera wants to merge 16 commits into
parkera wants to merge 16 commits into
Conversation
Contributor
Author
|
@swift-ci test |
1 similar comment
Contributor
Author
|
@swift-ci test |
phausler
reviewed
Mar 20, 2026
| return Duration.seconds(seconds) + Duration(secondsComponent: 0, attosecondsComponent: remainingTicks * 100_000_000_000) | ||
| #else | ||
| var ts = timespec() | ||
| clock_gettime(CLOCK_REALTIME, &ts) |
Contributor
There was a problem hiding this comment.
this is not monotonic btw:
CLOCK_REALTIME the system's real time (i.e. wall time) clock, expressed as the amount of time since the Epoch. This is the same as the value returned by
gettimeofday(2).
that can be adjusted by NTP or by the user adjusting the clock.
Contributor
Author
|
@swift-ci test |
Contributor
|
It looks like compiler is crashing in cmake build...? |
Contributor
Author
|
Yah we have to investigate that before merging the implementation but hopefully it wouldn’t delay a review. |
… producing v7 UUID
…does not also take a generator
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a new API proposal for UUID, plus corresponding implementation.
Motivation:
See the proposal for this.
Modifications:
New proposal, new implementation changes to support it, plus associated performance changes.
Result:
Benchmark shows 185% improvement in UUIDCreate, 23% improvement in UUIDString. Also removes the need for C shims for UUID.
Testing:
New unit tests, new benchmarks.