Fix relative path matching for nested ignore files on Windows#1216
Closed
somiljain2006 wants to merge 4 commits into
Closed
Fix relative path matching for nested ignore files on Windows#1216somiljain2006 wants to merge 4 commits into
somiljain2006 wants to merge 4 commits into
Conversation
Author
|
@allevato Can you review this pr? |
Author
|
The current approach doesn't appear to address the Windows failure, so I'm going to investigate this from a different angle. I'll reproduce and debug the issue on a local Windows environment to better understand the path and ignore-rule behavior before proposing another fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #1192
Improve path handling for nested
.swift-format-ignoreevaluation on Windows.This change updates
IgnoreManager.getRelativePath(from:to:)to make path matching more robust across platforms:SourcesmatchingSourcesTests.GitIgnorePatterns.With these changes,
fileIteratorWithMultipleNonEmptySwiftIgoreFilespasses without thewithKnownIssueworkaround, so the wrapper has been removed.Windows CI will provide final validation that this addresses the reported failure.