[Driver] Restrict flags to dependency scanner under explicit module b…#2148
Merged
Merged
Conversation
cachemeifyoucan
requested review from
DougGregor,
artemcm,
compnerd and
owenv
as code owners
Contributor
Author
|
@swift-ci please test |
artemcm
approved these changes
May 29, 2026
…uild In explicit module build mode, `-module-cache-path`, `-validate-clang-modules-once`, and `-clang-build-session-file` are only meaningful to the dependency scanner; other frontend jobs build modules from the resolved dependency graph and shouldn't consult the module cache or share a clang build session. Gate these flags so they are only forwarded to the `.scanDependencies` job when explicit module build is enabled. rdar://177651825
cachemeifyoucan
force-pushed
the
eng/PR-177651825
branch
from
d849dae to
d7e73c4
Compare
Contributor
Author
|
@swift-ci please test |
Contributor
Author
|
@swift-ci please test windows platform |
1 similar comment
Contributor
Author
|
@swift-ci please test windows platform |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…uild
In explicit module build mode,
-module-cache-path,-validate-clang-modules-once, and-clang-build-session-fileare only meaningful to the dependency scanner; other frontend jobs build modules from the resolved dependency graph and shouldn't consult the module cache or share a clang build session. Gate these flags so they are only forwarded to the.scanDependenciesjob when explicit module build is enabled.rdar://177651825