Add swap binary operands code action#2694
Open
somiljain2006 wants to merge 2 commits into
Open
Conversation
somiljain2006
requested review from
ahoppen,
hamishknight and
rintaro
as code owners
Contributor
Author
ahoppen
reviewed
Jun 19, 2026
|
|
||
| // Replace only the selected infix expression while leaving the | ||
| // surrounding folded expression tree unchanged. | ||
| let finalExpr = SwapRewriter(targetId: infixExpr.id, replacement: newInfix).visit(foldedExpr) |
Member
There was a problem hiding this comment.
Is this needed? Can’t you just replace infixExpr instead of exprToFold below?
Contributor
Author
There was a problem hiding this comment.
infixExpr is part of the detached tree returned by foldAll(), so it cannot be used directly to determine the edit range in the source file. Therefore, rewrite the folded tree and replace the original exprToFold range with the updated expression.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2520
Implement swap binary operands refactoring. Add a syntax-based code action that swaps the left and right operands of a binary expression when the cursor is positioned on the operator. Comparison operators are inverted as needed (for example,
<becomes>), while commutative operators are preserved. Add tests covering nested expressions, operator selection, unsupported operators, and trivia preservation.