Skip to content

Use local copy on action invocation#236

Merged
shahmishal merged 5 commits into
swiftlang:mainfrom
madrob:main
Feb 19, 2026
Merged

Use local copy on action invocation#236
shahmishal merged 5 commits into
swiftlang:mainfrom
madrob:main

Conversation

@madrob

@madrob madrob commented Feb 16, 2026

Copy link
Copy Markdown
Contributor

Fixes #220

@madrob madrob requested a review from a team as a code owner February 16, 2026 19:31
@madrob madrob marked this pull request as draft February 16, 2026 21:14
@madrob

madrob commented Feb 16, 2026

Copy link
Copy Markdown
Contributor Author

Looks like GITHUB_ACTION_PATH doesn't work the way that I thought it did. Investigating further.

@madrob

madrob commented Feb 16, 2026

Copy link
Copy Markdown
Contributor Author

Note to self, we might need to package those scripts inside of separate actions.

@madrob
Moving jobs with scripts into actions
b73041c 
Publishing as an action bundles the directory contents with the action, so we can use helper scripts directly
@madrob madrob marked this pull request as ready for review February 16, 2026 23:05
@madrob

madrob commented Feb 18, 2026

Copy link
Copy Markdown
Contributor Author

I think the failure is unrelated

@FranzBusch

FranzBusch commented Feb 18, 2026

Copy link
Copy Markdown
Member

Are you sure the broken symlink and python lint failures are unrelated?

@madrob

madrob commented Feb 18, 2026

Copy link
Copy Markdown
Contributor Author

The windows failure is the one I was referring to. Everything else seems passed?

@FranzBusch

FranzBusch commented Feb 18, 2026

Copy link
Copy Markdown
Member

The windows failure is the one I was referring to. Everything else seems passed?

I can see two jobs failing:

@madrob

madrob commented Feb 18, 2026

Copy link
Copy Markdown
Contributor Author

Oh, strange. I see those in the failed checks now, but earlier GitHub was telling me only one job failed. Fixed those in 854f793

@madrob

madrob commented Feb 18, 2026

Copy link
Copy Markdown
Contributor Author

Everything is green!

@shahmishal

shahmishal commented Feb 18, 2026

Copy link
Copy Markdown
Member

For the new action files, can you add read only permission?

permissions:
  contents: read

@madrob

madrob commented Feb 18, 2026

Copy link
Copy Markdown
Contributor Author

For the new action files, can you add read only permission?

Unlike .github/workflows, composite actions (files under .github/actions) cannot execute standalone and will always inherit the permissions from the calling workflow. There's no permission key to set on them.

see also: https://docs.github.com/en/actions/reference/workflows-and-actions/metadata-syntax

@madrob madrob mentioned this pull request Feb 19, 2026
Open
@shahmishal shahmishal merged commit c6fcbaf into swiftlang:main Feb 19, 2026
138 checks passed
@aryan-25 aryan-25 mentioned this pull request Feb 20, 2026
Merged
aryan-25 added a commit to swift-server/swift-http-server that referenced this pull request Feb 20, 2026
@aryan-25
Switch from main to 0.0.7 for swiftlang soundness workflow (#60)
4af762f 
Motivation:

In swiftlang/github-workflows#236, the locations
of soundness scripts were changed. As a result, all soundness CI checks
currently fail.

Modifications:

Replace `@main` with `0.0.7` in the soundness CI job declaration. 

Result:

Soundness CI checks will no longer be broken.
shahmishal added a commit that referenced this pull request Feb 20, 2026
@shahmishal
Revert "Use local copy on action invocation (#236)"
52442db 
This reverts commit c6fcbaf.
shahmishal added a commit that referenced this pull request Feb 20, 2026
@shahmishal
Revert Use local copy on action invocation (#239)
bca81f7 
* Revert "Add symlinks for backwards compatability (#238)"

This reverts commit 27ad4ac.

* Revert "Use local copy on action invocation (#236)"

This reverts commit c6fcbaf.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shahmishal shahmishal shahmishal approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Using a versioned soundness.yml as an external workflow does not propagate tag to checkout jobs

3 participants

@madrob @FranzBusch @shahmishal