v0.7.4.grt: fixes for os-gated warnings, remote claude login, and premature session exit#14
Open
grtakaha wants to merge 4 commits into
Open
v0.7.4.grt: fixes for os-gated warnings, remote claude login, and premature session exit#14grtakaha wants to merge 4 commits into
grtakaha wants to merge 4 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem 1: Claude was stalling on remote login.
* A bash command in ssh.rs with "exit" inside "{ }", which was prematurely exiting the parent shell - not just a subshell. This was fixed by using "( )" instead.
* check_remote_claude_auth() in claude.rs might have been killing the channel by trying to source the user's bash profile during authentication. Anything that calls "exit" here kills the session. Unsure if this was a primary problem, as the change to the above bash command was the one that ultimately worked, but leaving it as-is for now (see lines 1210-1224). This was fixed by removing the source profile command and just exporting PATH. From the comment above the source profile command, it seems like this might cause problems if Claude is in an unusual location - keep an eye on it.
Problem 2: There were a handful of Rust compiler warnings related to unused and/or OS-specific code.