chore(ls): add skill for reviewing apidom-ls changes against spec#5183
Open
robert-hebel-sb wants to merge 4 commits into
Open
chore(ls): add skill for reviewing apidom-ls changes against spec#5183robert-hebel-sb wants to merge 4 commits into
robert-hebel-sb wants to merge 4 commits into
Conversation
Adds a Claude Code skill that automates spec-compliance review of apidom-ls configuration for any specification namespace. The skill encodes lessons from the A2A 1.0 review (PROVCON-5343): curl+Python fallback for long spec pages, deprecated-flow detection, systematic scopes gap checks, anchor format rules per spec site, and a structured report template with spec citations for every finding. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Add coverage for type lint rules, completion file checks, discriminated union subtype registration, deprecated object detection, and enum/value-constraint rules — all gaps identified from the A2A 1.0 review comments. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…lessons Remove all A2A-specific references (examples, section headings, Key Lessons attribution) and generalize to apply to any spec namespace. Add improvements derived from PR #5110 review: new-field coverage when extending a parent version, version-scoped allowed-fields completeness, and array-of-objects linter function pattern. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
… skill Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.claude/skills/review-ls-changes/SKILL.md— a new Claude Code skill invoked via/review-ls-changes.claude/skills/SKILL-SUMMARY.mdwith an entry for the new skillThe skill performs structured spec-compliance reviews of
apidom-lsconfiguration for any specification namespace. It checks:config.ts)The skill was developed from the A2A 1.0 implementation review (PROVCON-5343) and encodes the lessons learned:
scopes--required.tsgap pattern across OAuth flows/specification/uses numbered anchors;/definitions/uses kebab-case)Test plan
/review-ls-changesin a Claude Code session and confirm it prompts for spec URL, config dir, and namespace packagehttps://a2a-protocol.org/latest/specification/packages/apidom-ls/src/config/a2a/and confirm report structure matches the template🤖 Generated with Claude Code