Open
Conversation
github-actions
Bot
added
app:activemembers
…s, event registrations
stefanvi
force-pushed
the
implement-import-export-library
branch
from
2c64946 to
7c23faa
Compare
| now = timezone.now() | ||
| self.queryset = self.queryset.select_related("member", "group") | ||
|
|
||
| # Show only memberships that are active now. |
Contributor
There was a problem hiding this comment.
Why did you delete this?
Contributor
Author
There was a problem hiding this comment.
Good catch! I think what happened is that when I copied the code from the older branch (which was a mess), I accidentally copied the old implementation for this class as well. I've fixed it now locally.
Unfortunately, I've also found another issue, because it seems like it's not possible to export only selected users from the separate Member export page. You can only export every member. I'll see if I can find a solution before pushing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1081
Duplicate of #2665 because creating a new branch was easier than fixing that one
This list below shows which classes still need to be implemented.
The last two are difficult because they have querysets that contain the actual data that needs to be exported. Registrations in case of Event and Payments in case of Batch. Also, the current event exporter has a lot of additional logic, which makes it difficult to define a resource class for it.
How to test: go to the admin page and navigate to one of the items on the list. Then in the dropdown there will be an option to export, where you can also choose the export file type. One exception is the export for users. This one allows two types of exports (UserList and UserEmailList). This is a fairly new feature of the library and does not (yet) support the inline dropdown that the other one uses. Instead, there is an export button that brings you to a separate page.
User export
Other export
