Pending Agreement: Add Support for Epoch Semver#114
Draft
jtannas wants to merge 9 commits intosvenfuchs:masterfrom
Draft
Pending Agreement: Add Support for Epoch Semver#114jtannas wants to merge 9 commits intosvenfuchs:masterfrom
jtannas wants to merge 9 commits intosvenfuchs:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR to add support for the feature proposed in #113
Putting it up early as a proof-of-concept and as a demonstration that I'm willing to do the work.There's some comments in it that should be reviewed but otherwise I don't see much more work to be done.
$ bundle exec gem bump -v epoch --no-commitbehaved as expected.$ bundle exec gem bootstrap tmpbehaved as expected.Leaving it as draft until there's agreement to add the feature so that discussion stays in the linked issue.
P.S. You'll probably want to squash merge my commits since there's a lot of "guess and test" going on.