Skip to content

Conversation

@jycouet
Copy link
Contributor

@jycouet jycouet commented Jan 21, 2026

Closes: #368

@changeset-bot
Copy link

changeset-bot bot commented Jan 21, 2026

🦋 Changeset detected

Latest commit: c8c44b9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte-migrate Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@svelte-docs-bot
Copy link

@pkg-pr-new
Copy link

pkg-pr-new bot commented Jan 21, 2026

Open in StackBlitz

npx https://pkg.pr.new/sveltejs/cli/svelte-migrate@890
npx https://pkg.pr.new/sveltejs/cli/sv@890

commit: c8c44b9

Copy link
Member

@manuel3108 manuel3108 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

// Skip if inside a comment (check if // appears on the same line before the match)
const line_start = before.lastIndexOf('\n') + 1;
const line_before_match = before.slice(line_start);
if (line_before_match.includes('//')) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about for multi-line comments?

@jycouet jycouet merged commit 717d90b into main Jan 23, 2026
8 checks passed
@jycouet jycouet deleted the fix/migration-app-state branch January 23, 2026 18:26
@github-actions github-actions bot mentioned this pull request Jan 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

npx sv migrate app-state only migrates some files

3 participants