Skip to content

chore(deps): drop picocolors for styleText of node:util #882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jycouet merged 7 commits into from
Jan 23, 2026
Merged

chore(deps): drop picocolors for styleText of node:util #882

jycouet merged 7 commits into from
Jan 23, 2026

Conversation

@jycouet
Copy link
Contributor

@jycouet jycouet commented Jan 20, 2026

Closes: #875

@changeset-bot
Copy link

changeset-bot bot commented Jan 20, 2026 •
edited
Loading

🦋 Changeset detected

Latest commit: 1979505

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
sv Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@svelte-docs-bot
Copy link

svelte-docs-bot bot commented Jan 20, 2026

Preview: https://svelte-dev-git-preview-cli-882-svelte.vercel.app/

@pkg-pr-new
Copy link

pkg-pr-new bot commented Jan 20, 2026 •
edited
Loading

Open in StackBlitz

npx https://pkg.pr.new/sveltejs/cli/svelte-migrate@882

npx https://pkg.pr.new/sveltejs/cli/sv@882

commit: 1979505

@jycouet
Copy link
Contributor Author

jycouet commented Jan 20, 2026

There is now ONE central place for colors (with semantic)
I tuned some... and it looks like

image

I'm not bound to these! you can play around

manuel3108
manuel3108 requested changes Jan 21, 2026
View reviewed changes
Copy link
Member

@manuel3108 manuel3108 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe I'm missing something, but in #875 there were talks about a node version check. I'm not seeing this here. Is there a reasoning?

Edit: There is a conflict as well.

@jycouet
Copy link
Contributor Author

jycouet commented Jan 21, 2026 •
edited
Loading

Tentative of a small update
image

manuel3108
manuel3108 approved these changes Jan 23, 2026
View reviewed changes
Copy link
Member

@manuel3108 manuel3108 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, the node check is probably not necessary, as node 20 was released in april 2023, so people should have upgraded by now.

@manuel3108
Copy link
Member

manuel3108 commented Jan 23, 2026

Edit: Not merging, not sure if you don't want to add a changeset. I don't think it's necessary here, but maybe because of the potentially breaking behaviour for some users?

@jycouet jycouet merged commit 69288db into main Jan 23, 2026
8 checks passed
@jycouet jycouet deleted the chore/rmv-picocolors branch January 23, 2026 18:29
@github-actions github-actions bot mentioned this pull request Jan 23, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@manuel3108 manuel3108 manuel3108 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

replace picocolor with styleText

3 participants

@jycouet @manuel3108