Skip to content

Improve CI/CD and build setup#21

Merged
sv2dev merged 3 commits intomainfrom
improve/ci-cd-and-build
Mar 31, 2026
Merged

Improve CI/CD and build setup#21
sv2dev merged 3 commits intomainfrom
improve/ci-cd-and-build

Conversation

@sv2dev
Copy link
Copy Markdown
Owner

@sv2dev sv2dev commented Mar 31, 2026

Summary

  • Add composite project references to top-level tsconfig.json for building all workspace packages with tsc -b
  • Merge publish-core and publish-lit jobs into single publish job with conditional steps
  • Publish job only runs if at least one package version changed
  • Update Node.js version to 24 and actions/setup-node to v6
  • Include source maps in npm packages for better debugging

What changed

  • Top-level tsconfig now includes workspace package references for incremental builds
  • GitHub Actions publish workflow is now more efficient and uses OIDC for authentication
  • Fixed .npmignore to not exclude .map files

Summary by CodeRabbit

  • New Features

    • Source maps now included in published packages for improved debugging capabilities.
  • Chores

    • Released patch version 0.11.1 for both esroute and esroute-lit packages.
    • Updated build infrastructure to Node.js 24.

Sven Rogge added 2 commits March 31, 2026 15:37
- Add composite project references to top-level tsconfig.json for building all workspace packages with `tsc -b`
- Merge publish-core and publish-lit jobs into single publish job with conditional steps
- Merge both jobs only run if at least one package version changed
- Update Node.js version to 24 and actions/setup-node to v6
- Already using OIDC with --provenance flag
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 31, 2026

Caution

Review failed

Pull request was closed or merged during review

Walkthrough

This PR consolidates separate GitHub Actions publishing jobs into a single conditionally-triggered job, updates Node.js setup to v6 with version 24, adds TypeScript project references for multi-project configuration, and bumps package versions to 0.11.1 with source maps now included in npm distributions.

Changes

Cohort / File(s) Summary
GitHub Actions Workflow
.github/workflows/publish.yaml
Consolidates two separate publish-core and publish-lit jobs into a single publish job with conditional steps. Updates Node.js action from v4 to v6 and version from 22 to 24. Simplifies install step and removes explicit NODE_AUTH_TOKEN environment variable injection.
Package Versions
packages/esroute/package.json, packages/esroute-lit/package.json
Version bumps from 0.11.0 to 0.11.1. The esroute-lit package also updates its esroute dependency from ^0.11.0 to ^0.11.1.
NPM Distribution
packages/esroute/.npmignore
Removes the dist/**/*.map ignore pattern, allowing source map files to be included in the npm package distribution.
TypeScript Configuration
tsconfig.json
Adds project references section linking to packages/esroute and packages/esroute-lit, converting from single-project to multi-project TypeScript configuration.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

Poem

🐰 Two jobs hop into one,
Versions dance their latest run,
TypeScript references align,
Source maps shine, so fine!
The build graph takes its new design. ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Improve CI/CD and build setup' accurately reflects the main changes: CI/CD workflow consolidation, Node.js updates, and TypeScript build configuration improvements.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch improve/ci-cd-and-build

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sv2dev sv2dev merged commit 0ea622f into main Mar 31, 2026
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant