-
Notifications
You must be signed in to change notification settings - Fork 45
fix: throttle/debounce high-frequency WebSocket events to eliminate UI stuttering #73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Pratyush-Panda-2006
wants to merge
5
commits into
suresh1319:master
Choose a base branch
from
Pratyush-Panda-2006:fix/issue-67-throttle-websocket-events
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
49c603f
fix: throttle/debounce high-frequency WebSocket events to eliminate U…
Pratyush-Panda-2006 1153ca0
fix/issue-67-throttle-websocket-events
Pratyush-Panda-2006 a923b23
perf: harden throttle/debounce utilities, add comprehensive tests, fi…
Pratyush-Panda-2006 816ab41
fix: address all review findings — separate INVALID_PAYLOAD event, sl…
Pratyush-Panda-2006 be06ef5
fix: eliminate dual-signal error paths in FS_UPLOAD_BATCH to prevent …
Pratyush-Panda-2006 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,15 +1,15 @@ | ||
| { | ||
| "files": { | ||
| "main.css": "/static/css/main.42b54382.css", | ||
| "main.js": "/static/js/main.82214ec4.js", | ||
| "main.css": "/static/css/main.9809cef7.css", | ||
| "main.js": "/static/js/main.24668c71.js", | ||
| "static/js/453.5620f6ad.chunk.js": "/static/js/453.5620f6ad.chunk.js", | ||
| "index.html": "/index.html", | ||
| "main.42b54382.css.map": "/static/css/main.42b54382.css.map", | ||
| "main.82214ec4.js.map": "/static/js/main.82214ec4.js.map", | ||
| "main.9809cef7.css.map": "/static/css/main.9809cef7.css.map", | ||
| "main.24668c71.js.map": "/static/js/main.24668c71.js.map", | ||
| "453.5620f6ad.chunk.js.map": "/static/js/453.5620f6ad.chunk.js.map" | ||
| }, | ||
| "entrypoints": [ | ||
| "static/css/main.42b54382.css", | ||
| "static/js/main.82214ec4.js" | ||
| "static/css/main.9809cef7.css", | ||
| "static/js/main.24668c71.js" | ||
| ] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| <!doctype html><html lang="en"><head><meta charset="utf-8"/><link rel="icon" href="/favicon.png"/><meta name="viewport" content="width=device-width,initial-scale=1"/><meta name="theme-color" content="#000000"/><meta name="description" content="Web site created using create-react-app"/><link rel="apple-touch-icon" href="/logo192.png"/><link rel="manifest" href="/manifest.json"/><title>CollabCE</title><script defer="defer" src="/static/js/main.82214ec4.js"></script><link href="/static/css/main.42b54382.css" rel="stylesheet"></head><body><noscript>You need to enable JavaScript to run this app.</noscript><div id="root"></div></body></html> | ||
| <!doctype html><html lang="en"><head><meta charset="utf-8"/><link rel="icon" href="/favicon.png"/><meta name="viewport" content="width=device-width,initial-scale=1"/><meta name="theme-color" content="#000000"/><meta name="description" content="Web site created using create-react-app"/><link rel="apple-touch-icon" href="/logo192.png"/><link rel="manifest" href="/manifest.json"/><title>CollabCE</title><script defer="defer" src="/static/js/main.24668c71.js"></script><link href="/static/css/main.9809cef7.css" rel="stylesheet"></head><body><noscript>You need to enable JavaScript to run this app.</noscript><div id="root"></div></body></html> |
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
server.js:205-208 emits INVALID_PAYLOAD AND calls reply(false, …) for the same validation failure. EditorPage.js handles both: the INVALID_PAYLOAD socket listener (line 245) fires toast.error, and the FS_UPLOAD_BATCH ack callback (line 567) also fires toast.error — showing two identical toasts.
Prompt to fix with AI