Revert "fix(backend): add size limits on uploaded file contents to prevent memory exhaustion"#148
Merged
Conversation
…event memory exhaustion"
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reverts the previously-added upload size enforcement for batched file uploads, removing both client-side and server-side limits around uploaded file contents.
Changes:
- Removes client-side per-file content size checks during upload (EditorPage upload handler).
- Removes server-side validation for per-file and per-room stored content size before persisting uploads (FS_UPLOAD_BATCH handler).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/pages/EditorPage.js |
Reverts client-side size-guard logic and adjusts upload reading flow for images/binary/text files. |
server.js |
Reverts server-side fileContents size validation prior to mutating room file state. |
Comments suppressed due to low confidence (1)
server.js:319
- FS_UPLOAD_BATCH stores arbitrary fileContents into in-memory room state without any size limits. A client can repeatedly upload <=1MB chunks (or whatever Socket.IO allows) and grow roomState[roomId].fileContents without bound, reintroducing the memory-exhaustion/DoS risk that the reverted change was mitigating. Validate per-file and per-room cumulative size before mutating the file system / contents map, and reject the upload with an ack message when limits are exceeded.
for (const node of nodes) {
fs[node.id] = node;
if (fs[node.parentId]) {
if (!fs[node.parentId].children) fs[node.parentId].children = [];
// Avoid adding duplicate child references
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+624
to
+627
| const fileId = uuid(); | ||
| // Always add the node so binary files appear in the file tree | ||
| nodesToCreate.push({ id: fileId, name: file.name, type: 'file', parentId }); | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #139