Skip to content

Fix: Aligned the content of hero section#122

Open
vedikabajaj05 wants to merge 4 commits into
suresh1319:masterfrom
vedikabajaj05:feature/hero-section
Open

Fix: Aligned the content of hero section#122
vedikabajaj05 wants to merge 4 commits into
suresh1319:masterfrom
vedikabajaj05:feature/hero-section

Conversation

@vedikabajaj05
Copy link
Copy Markdown
Contributor

feat: improve hero section alignment and positioning for better map-centered layout

What changed?
Repositioned the hero content block to align more naturally with the central map visual.
Shifted the main hero text (Code together, anywhere on earth) slightly to the left for better balance under the top-center collaboration pin.
Updated .hero-content from relative positioning to absolute positioning for more precise placement.
Fine-tuned horizontal and vertical alignment using top, left, and transform.
Maintained responsiveness and preserved existing CTA/button alignment.
Why is this needed?

Previously, the hero content was centered relative to the full viewport, which made it feel visually disconnected from the collaborative map illustration and floating pins. This update improves hierarchy and creates a stronger visual relationship between the hero message and the interactive map.

Connection with PR #107
issue number #92

This PR builds on PR #107, which introduced/refined the hero map visuals and collaboration pin layout. While PR #107 improved the visual structure of the hero background, this PR focuses on aligning the content block more accurately with that design system, ensuring the hero text sits naturally beneath the primary collaboration pin and feels more compositionally balanced.

Impact
Better visual balance in hero section
Improved UX and readability
Stronger connection between content and collaborative map illustration
Cleaner responsive hero layout without affecting existing interactions

@vedikabajaj05
Copy link
Copy Markdown
Contributor Author

Screenshot 2026-05-25 155221

@vedikabajaj05
Copy link
Copy Markdown
Contributor Author

@suresh1319 , Please Check!

Comment thread src/index.css Outdated
@entelligence-ai-pr-reviews
Copy link
Copy Markdown
Contributor


Confidence Score: 4/5 - Mostly Safe

Likely safe but review recommended — this PR correctly aligns the hero section content as intended, achieving its stated goal. However, src/index.css contains a dead top: 52% declaration that is silently overridden by top: 40% on line 96 within the same rule, leaving dead code that could confuse future maintainers. The fix is trivial — removing the unused top: 52% line — but the nit is worth addressing before merge to keep the stylesheet clean.

Key Findings:

  • In src/index.css, top is declared twice in the same CSS rule: the first value 52% is silently discarded because top: 40% overrides it on line 96, leaving dead code with no runtime effect but reducing readability.
  • The PR's core change — aligning hero section content — appears functionally correct and achieves its stated purpose; the only flagged issue is cosmetic dead code, not a logic or correctness bug.
  • No logic, security, or performance issues were identified across the single changed file.
Files requiring special attention
  • src/index.css

@entelligence-ai-pr-reviews
Copy link
Copy Markdown
Contributor

entelligence-ai-pr-reviews Bot commented May 25, 2026

EntelligenceAI PR Summary

Hardcodes the pulse dot background color in src/index.css, removing the --accent-color CSS variable reference.

  • Replaced var(--accent-color, #4aed88) with the literal value #4aed88 in src/index.css
  • Removes the ability to dynamically theme the pulse dot color via the --accent-color CSS custom property

Confidence Score: 4/5 - Mostly Safe

Safe to merge — this PR makes a focused, minimal change in src/index.css by replacing var(--accent-color, #4aed88) with the hardcoded literal #4aed88 for the pulse dot background color. The change achieves its stated goal of fixing hero section alignment-related styling without introducing any logic bugs, runtime errors, or security concerns. The one trade-off worth noting is the deliberate removal of dynamic theming support via the --accent-color CSS custom property, which is a design decision rather than a defect, but warrants awareness if theming extensibility is a future concern.

Key Findings:

  • The change in src/index.css is purely cosmetic at runtime — replacing var(--accent-color, #4aed88) with #4aed88 produces identical visual output in the current context since the fallback value is preserved as the new literal.
  • Removing the --accent-color CSS variable reference reduces theming flexibility; if other parts of the codebase or consumer themes rely on --accent-color to dynamically style the pulse dot, this change silently breaks that contract.
  • No new issues were introduced: coverage is 1/1 changed files reviewed, there are no unresolved prior comments, and the diff scope is tightly bounded to a single CSS property change.
Files requiring special attention
  • src/index.css

Comment thread src/index.css Outdated
Co-authored-by: entelligence-ai-pr-reviews[bot] <174136889+entelligence-ai-pr-reviews[bot]@users.noreply.github.com>
@suresh1319
Copy link
Copy Markdown
Owner

hi @vedikabajaj05 please resolve the conflicts and mention the issue number

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants