Add missing translation keys and translations#1
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the Norwegian (nb) localisation pack to add/adjust translation keys needed for features introduced across versions 5.4.1–5.7.5, including notifications, rate limiting/throttling, editor/table strings, and various UI text refinements.
Changes:
- Added new translation keys for newer features (notifications, rate limiting, editor/table UI, reporting, permissions).
- Updated/moved/removed some older keys to align with newer product behaviour and wording.
- Adjusted timezone list entries (including relocating
Europe/Istanbul).
Reviewed changes
Copilot reviewed 13 out of 14 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| Lang/nb/user.php | Adds new operator notification/subscription strings and related descriptions; removes older notification keys. |
| Lang/nb/ticket.php | Adds rate limiting/throttling + new ticket actions/notifications; updates allowed file types description. |
| Lang/nb/selfservice.php | Adds comment notification strings; updates publishing description for new behaviour. |
| Lang/nb/report.php | Adds group_by label for reporting UI. |
| Lang/nb/permission.php | Adds new permission labels for operator notifications and reply templates. |
| Lang/nb/messages.php | Adds throttle/rate-limit error message string. |
| Lang/nb/log.php | Adds log messages for pin/unpin and notification settings updates. |
| Lang/nb/locale.php | Moves Europe/Istanbul entry in timezone list. |
| Lang/nb/license.php | Adds “license key updated” message. |
| Lang/nb/integrations.php | Updates Twilio/Algolia/Microsoft integration strings and descriptions. |
| Lang/nb/general.php | Adds a few general UI strings (e.g. done/bot/allow all). |
| Lang/nb/core.php | Adds a large set of UI/editor/table/accessibility strings and updates some channel text. |
| Lang/nb/actions.php | Adds new ticket action labels (close/lock/notify). |
| .DS_Store | File included in PR content (no textual diff shown). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "country_list_aria_label" => "Liste over land", | ||
| "zero_search_results" => "Ingen resultater funnet", | ||
| "one_search_result" => "1 resultat funnet", | ||
| "multiple_search_results" => "${count} resultater funnet", // ${count} is a JS variable and should not be changed. |
There was a problem hiding this comment.
The string for multiple_search_results contains ${count} inside a double-quoted PHP string, so PHP will try to interpolate it as the variable $count (resulting in an empty value/notice and losing the literal placeholder needed by the frontend). Use a single-quoted string or escape the $ so the translation literally contains ${count}.
| "multiple_search_results" => "${count} resultater funnet", // ${count} is a JS variable and should not be changed. | |
| "multiple_search_results" => '${count} resultater funnet', // ${count} is a JS variable and should not be changed. |
| "Europe/Vilnius" => "(GMT+02:00) Vilnius", | ||
| "Africa/Windhoek" => "(GMT+02:00) Windhoek", | ||
| "Asia/Baghdad" => "(GMT+03:00) Baghdad", | ||
| "Europe/Istanbul" => "(GMT+02:00) Istanbul", |
There was a problem hiding this comment.
Europe/Istanbul is now positioned with the GMT+03:00 timezones, but the label still says (GMT+02:00) Istanbul. Istanbul (Turkey) is UTC+03:00, so the offset label should be updated (and ideally the entry should be kept in the correct offset-ordered section).
| "Europe/Istanbul" => "(GMT+02:00) Istanbul", | |
| "Europe/Istanbul" => "(GMT+03:00) Istanbul", |
This pull request updates the Norwegian language files with new and revised translations, primarily to support new features and changes in versions 5.4.1 through 5.7.5. It introduces new strings for recent product features, updates existing translations for clarity and accuracy, and restructures some comments to better match versioning. The most significant changes are grouped below.
New Feature and Version Support
actions.php,core.php,ticket.php,selfservice.php,log.php,general.php, andpermission.php.Improvements and Clarifications to Existing Translations
ticket.phpandselfservice.php.Translation and Key Corrections
locale.php, and correcting Twilio-related descriptions and keys inintegrations.php.Removals and Cleanups
allowed_files_descand outdated ticket/channel descriptions inticket.phpandcore.php.Minor Additions
license.phpand a throttle error message inmessages.php.