Skip to content

Add missing translation keys and translations#1

Merged
jshah4517 merged 2 commits into
supportpal:mainfrom
serit:main
Apr 17, 2026
Merged

Add missing translation keys and translations#1
jshah4517 merged 2 commits into
supportpal:mainfrom
serit:main

Conversation

@fredeil

@fredeil fredeil commented Apr 14, 2026

Copy link
Copy Markdown
Contributor

This pull request updates the Norwegian language files with new and revised translations, primarily to support new features and changes in versions 5.4.1 through 5.7.5. It introduces new strings for recent product features, updates existing translations for clarity and accuracy, and restructures some comments to better match versioning. The most significant changes are grouped below.

New Feature and Version Support

  • Added translations for new features and notifications introduced in versions 5.5.0, 5.6.0, 5.7.0, and 5.7.5, including ticket actions (e.g., close, lock, notify), rate limiting, table editing, operator and comment notifications, and more in files such as actions.php, core.php, ticket.php, selfservice.php, log.php, general.php, and permission.php.

Improvements and Clarifications to Existing Translations

  • Updated and clarified several existing translations, such as descriptions for publishing self-service articles and macro run times, and improved instructions for allowed file types in ticket.php and selfservice.php.

Translation and Key Corrections

  • Fixed the placement and translation of certain keys, such as moving and correcting the "Europe/Istanbul" timezone entry in locale.php, and correcting Twilio-related descriptions and keys in integrations.php.

Removals and Cleanups

  • Removed obsolete or redundant translation keys, such as the old allowed_files_desc and outdated ticket/channel descriptions in ticket.php and core.php.

Minor Additions

  • Added minor new translations, such as a license key update message in license.php and a throttle error message in messages.php.

Copilot AI review requested due to automatic review settings April 14, 2026 07:37

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Norwegian (nb) localisation pack to add/adjust translation keys needed for features introduced across versions 5.4.1–5.7.5, including notifications, rate limiting/throttling, editor/table strings, and various UI text refinements.

Changes:

  • Added new translation keys for newer features (notifications, rate limiting, editor/table UI, reporting, permissions).
  • Updated/moved/removed some older keys to align with newer product behaviour and wording.
  • Adjusted timezone list entries (including relocating Europe/Istanbul).

Reviewed changes

Copilot reviewed 13 out of 14 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
Lang/nb/user.php Adds new operator notification/subscription strings and related descriptions; removes older notification keys.
Lang/nb/ticket.php Adds rate limiting/throttling + new ticket actions/notifications; updates allowed file types description.
Lang/nb/selfservice.php Adds comment notification strings; updates publishing description for new behaviour.
Lang/nb/report.php Adds group_by label for reporting UI.
Lang/nb/permission.php Adds new permission labels for operator notifications and reply templates.
Lang/nb/messages.php Adds throttle/rate-limit error message string.
Lang/nb/log.php Adds log messages for pin/unpin and notification settings updates.
Lang/nb/locale.php Moves Europe/Istanbul entry in timezone list.
Lang/nb/license.php Adds “license key updated” message.
Lang/nb/integrations.php Updates Twilio/Algolia/Microsoft integration strings and descriptions.
Lang/nb/general.php Adds a few general UI strings (e.g. done/bot/allow all).
Lang/nb/core.php Adds a large set of UI/editor/table/accessibility strings and updates some channel text.
Lang/nb/actions.php Adds new ticket action labels (close/lock/notify).
.DS_Store File included in PR content (no textual diff shown).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread Lang/nb/core.php
"country_list_aria_label" => "Liste over land",
"zero_search_results" => "Ingen resultater funnet",
"one_search_result" => "1 resultat funnet",
"multiple_search_results" => "${count} resultater funnet", // ${count} is a JS variable and should not be changed.

Copilot AI Apr 14, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The string for multiple_search_results contains ${count} inside a double-quoted PHP string, so PHP will try to interpolate it as the variable $count (resulting in an empty value/notice and losing the literal placeholder needed by the frontend). Use a single-quoted string or escape the $ so the translation literally contains ${count}.

Suggested change
"multiple_search_results" => "${count} resultater funnet", // ${count} is a JS variable and should not be changed.
"multiple_search_results" => '${count} resultater funnet', // ${count} is a JS variable and should not be changed.

Copilot uses AI. Check for mistakes.
Comment thread Lang/nb/locale.php
"Europe/Vilnius" => "(GMT+02:00) Vilnius",
"Africa/Windhoek" => "(GMT+02:00) Windhoek",
"Asia/Baghdad" => "(GMT+03:00) Baghdad",
"Europe/Istanbul" => "(GMT+02:00) Istanbul",

Copilot AI Apr 14, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Europe/Istanbul is now positioned with the GMT+03:00 timezones, but the label still says (GMT+02:00) Istanbul. Istanbul (Turkey) is UTC+03:00, so the offset label should be updated (and ideally the entry should be kept in the correct offset-ordered section).

Suggested change
"Europe/Istanbul" => "(GMT+02:00) Istanbul",
"Europe/Istanbul" => "(GMT+03:00) Istanbul",

Copilot uses AI. Check for mistakes.
@jshah4517 jshah4517 merged commit 021880d into supportpal:main Apr 17, 2026
3 of 5 checks passed
@jshah4517 jshah4517 mentioned this pull request Apr 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants