fix(deploy): fix post-deploy DNS check for non-standard ports and private IPs#4742
Merged
fix(deploy): fix post-deploy DNS check for non-standard ports and private IPs#4742
Conversation
dangra
force-pushed
the
fix-dns-check-port
branch
from
11026d8 to
28cd61f
Compare
…vate IPs Two fixes: - Use appURL.Hostname() instead of appURL.Host to strip the port from the hostname before DNS lookup, preventing queries for invalid names like "app.fly.dev:8192." - Exclude ULA (fc00::/7) IPv6 addresses (flycast, 6PN) from the expected AAAA record count since they are private and not published in fly.dev DNS.
dangra
changed the title
dangra
force-pushed
the
fix-dns-check-port
branch
from
28cd61f to
c884dec
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
appURL.Hostname()instead ofappURL.Hostto strip the port from the hostname before DNS lookup, preventing queries for invalid names likeapp.fly.dev:8192.fc00::/7) IPv6 addresses (flycast, 6PN) from the expected AAAA record count since they are private and not published in fly.dev DNSTest plan