Improve error message for invalid bucket name length in storage create#4729
Closed
kubosuke wants to merge 1 commit intosuperfly:masterfrom
Closed
Improve error message for invalid bucket name length in storage create#4729kubosuke wants to merge 1 commit intosuperfly:masterfrom
storage create#4729kubosuke wants to merge 1 commit intosuperfly:masterfrom
Conversation
When a bucket name exceeds 63 characters (or is less than 3), the API returns a generic error message 'The specified bucket is not valid'. This change adds client-side validation to provide a clear error message that explains the length constraint and includes a link to the Tigris bucket naming rules documentation. Example error: bucket name "..." is too long: must be at most 63 characters, got 64. See https://www.tigrisdata.com/docs/buckets/bucket-rules/
dangra
reviewed
Feb 24, 2026
| } | ||
|
|
||
| func runCreate(ctx context.Context) (err error) { | ||
| bucketName := flag.GetString(ctx, "name") |
Member
There was a problem hiding this comment.
this is fun stuff because I can't find where the bucket name is passed to Tigris extension. It is like the --name cli flag is completely ignored
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
What and Why:
When creating a storage bucket with an invalid name length, the API returns a generic error:
The specified bucket is not valid. This makes it hard for users to understand the issue.How:
Added client-side validation to check bucket name length (3-63 characters) before calling the API, with a clear error message and link to docs.
Related to:
N/A
Documentation