Skip to content

Conversation

@samrose
Copy link
Collaborator

@samrose samrose commented Dec 31, 2025

The location of true in macos is /usr/bin/true and adding this logic fixes the archiving command function when running postgres locally in macos using nix run .#start-server <version> command

Summary by CodeRabbit

Bug Fixes

  • Fixed server startup configuration on macOS systems to correctly handle archive command settings.

✏️ Tip: You can customize this high-level summary in your review settings.

@samrose samrose requested review from a team as code owners December 31, 2025 15:40
@coderabbitai
Copy link

coderabbitai bot commented Dec 31, 2025

Walkthrough

This change adds a macOS-specific post-configuration step to the server startup script that corrects PostgreSQL's archive_command setting by replacing /bin/true with /usr/bin/true in postgresql.conf when running on Darwin systems.

Changes

Cohort / File(s) Summary
macOS configuration fix
nix/tools/run-server.sh.in
Adds conditional logic to replace archive_command path from /bin/true to /usr/bin/true in postgresql.conf after orioledb_config_items step when CURRENT_SYSTEM is Darwin

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 A hop through Darwin's sunlit way,
Where true commands now brightly play,
From /bin to /usr/bin we leap and bound,
PostgreSQL's archive, safe and sound! ✨

Pre-merge checks

❌ Failed checks (1 warning, 1 inconclusive)
Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description lacks the required template structure specified in the repository, containing only a brief explanation without using the designated sub-templates. Follow the repository's PR description template by selecting and using the appropriate sub-template (Default or Extension Upgrade) from the Preview tab.
Title check ❓ Inconclusive The title 'Run server macos' is vague and generic, using non-descriptive terms that don't convey the specific change being made. Use a more specific title that describes the actual change, such as 'Fix archive command path for macOS in run-server script' or 'Update true binary path for macOS compatibility'.
✅ Passed checks (1 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

📜 Recent review details

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a31845e and 8e5925b.

📒 Files selected for processing (1)
  • nix/tools/run-server.sh.in
🚧 Files skipped from review as they are similar to previous changes (1)
  • nix/tools/run-server.sh.in
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: no packages to build (aarch64-linux)
  • GitHub Check: no packages to build (x86_64-linux)
  • GitHub Check: no packages to build (aarch64-darwin)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

(deprecated due to error in changes pushed)

@samrose samrose added this pull request to the merge queue Dec 31, 2025
Merged via the queue into develop with commit acb688a Dec 31, 2025
19 checks passed
@samrose samrose deleted the run-server-macos branch December 31, 2025 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants