Fix scrolling in settings#18
Open
groszdaniel wants to merge 1 commit intosunsetsonwheels:masterfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Settings menu scrolls weirdly when going down or up, compared to how one expects it to work from other systems. This fixes it by using a ponyfill for the
scrollIntoViewIfNeededmethod of Chromium-based browsers, or theblock: "nearest"option of thescrollIntoViewmethod of newer Firefox versions, which scroll the view by only as much as needed. (This is a common issue with list views in Kaios apps, including stock apps, since developers often use the plain scrollIntoView function, which is inappropriate for the purpose. I'm going to upload some patches on bananahackers to fix it where possible, using the same ponyfill.)