Fix Phantom wallet signing order for multi-signer transactions#315
Merged
dankelleher merged 1 commit intodevelopfrom Mar 2, 2026
Merged
Fix Phantom wallet signing order for multi-signer transactions#315dankelleher merged 1 commit intodevelopfrom
dankelleher merged 1 commit intodevelopfrom
Conversation
Phantom's Lighthouse security system requires the wallet to sign transactions before other signers. This fix implements the correct signing order in two places: 1. SunriseStakeClient.sendAndConfirmTransaction - Added a custom signing path for transactions with additional signers that signs with the wallet first, then adds partial signatures. 2. withdrawBlaze.ts script - Fixed the signing order in createStakeAccount to match Phantom's requirements. Also fixed a bug where confirm() was called incorrectly with this.provider instead of this.provider.connection.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phantom's Lighthouse security system requires the wallet to sign transactions before other signers. This fix implements the correct signing order in two places:
SunriseStakeClient.sendAndConfirmTransaction - Added a custom signing path for transactions with additional signers that signs with the wallet first, then adds partial signatures.
withdrawBlaze.ts script - Fixed the signing order in createStakeAccount to match Phantom's requirements.
Also fixed a bug where confirm() was called incorrectly with this.provider instead of this.provider.connection.