Skip to content

Client compression for replication #468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sundb wants to merge 7 commits into
base: unstable
Choose a base branch
from
Open

Client compression for replication #468

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
e24ecd8
Client compression for replication
minchopaskal Sep 25, 2025
51c0130
Fix mem leaks and minor issues from review
minchopaskal Mar 25, 2026
caade6a
Fix review comments
minchopaskal Mar 26, 2026
71fe177
remove unused client flag
minchopaskal Mar 26, 2026
7aee551
Fix maxattempts count in wait_for_sync proc in tests
minchopaskal Mar 27, 2026
e95e251
fix minor issues
minchopaskal Jun 2, 2026
6ea000b
test
sundb Jun 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 18 additions & 8 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,9 @@ jobs:
- name: make
# Fail build if there are warnings
# build with TLS just for compilation coverage
run: make REDIS_CFLAGS='-Werror' BUILD_TLS=yes
run: |
sudo apt-get install -y libzstd-dev
make REDIS_CFLAGS='-Werror' BUILD_TLS=yes
- name: test
run: |
sudo apt-get install tcl8.6 tclx
Expand All @@ -33,7 +35,9 @@ jobs:
- uses: actions/checkout@v6
- name: make
# build with TLS module just for compilation coverage
run: make SANITIZER=address REDIS_CFLAGS='-Werror -DDEBUG_ASSERTIONS -DREDIS_TEST' BUILD_TLS=module
run: |
sudo apt-get install -y libzstd-dev
make SANITIZER=address REDIS_CFLAGS='-Werror -DDEBUG_ASSERTIONS -DREDIS_TEST' BUILD_TLS=module
- name: testprep
run: sudo apt-get install tcl8.6 tclx -y
- name: test
Expand All @@ -48,7 +52,8 @@ jobs:
run: |
sed -i 's|http://deb.debian.org/debian|http://archive.debian.org/debian|g' /etc/apt/sources.list
sed -i 's|http://security.debian.org|http://archive.debian.org/debian-security|g' /etc/apt/sources.list
apt-get update && apt-get install -y build-essential
echo "deb http://archive.debian.org/debian buster-backports main" >> /etc/apt/sources.list
apt-get update && apt-get install -y build-essential libzstd-dev/buster-backports
make REDIS_CFLAGS='-Werror'

build-macos-latest:
Expand All @@ -58,23 +63,28 @@ jobs:
- name: make
# Fail build if there are warnings
# build with TLS just for compilation coverage
run: make REDIS_CFLAGS='-Werror' BUILD_TLS=yes
run: |
brew install zstd
make REDIS_CFLAGS='-Werror' BUILD_TLS=yes

build-32bit:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v6
- name: make
run: |
sudo apt-get update && sudo apt-get install libc6-dev-i386 gcc-multilib
sudo dpkg --add-architecture i386
sudo apt-get update && sudo apt-get install libc6-dev-i386 gcc-multilib libzstd-dev:i386
make REDIS_CFLAGS='-Werror' 32bit

build-libc-malloc:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v6
- name: make
run: make REDIS_CFLAGS='-Werror' MALLOC=libc
run: |
sudo apt-get install -y libzstd-dev
make REDIS_CFLAGS='-Werror' MALLOC=libc

build-centos-jemalloc:
runs-on: ubuntu-latest
Expand All @@ -83,7 +93,7 @@ jobs:
- uses: actions/checkout@v6
- name: make
run: |
dnf -y install which gcc make
dnf -y install which gcc make libzstd-devel
make REDIS_CFLAGS='-Werror'

build-old-chain-jemalloc:
Expand All @@ -100,6 +110,6 @@ jobs:
apt-key adv --keyserver keyserver.ubuntu.com --recv-keys 40976EAF437D05B5
apt-key adv --keyserver keyserver.ubuntu.com --recv-keys 3B4FE6ACC0B21F32
apt-get update
apt-get install -y make gcc-4.8
apt-get install -y make gcc-4.8 libzstd-dev
update-alternatives --install /usr/bin/gcc gcc /usr/bin/gcc-4.8 100
make CC=gcc REDIS_CFLAGS='-Werror'
Loading
Loading