-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Fix issue #4794 corrected Pitch block drag-and-drop behavior to match… #4797
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
… to match Name block
|
✅ All Jest tests passed! This PR is ready to merge. |
|
apologies for the messy PR with removing spaces for no reason (my VS code extensions would have do that) |
|
The Key changes is this: Screen.Recording.2025-11-11.160030.mp4I have tested the code and sorry to say that the code doen't resolve the issue... The issue still persists |
|
@harshrajsoni |
|
but the PR is created for different issue i think |
|
@harshrajsoni |
|
Could you please separate your linting changes from your bug fix into two separate commits? (They can remain in the same PR.) |
|
@pikurasa do you agree with this UX change? |
|
@pikurasa we still need to discuss this one from the UX perspective. |
Summary
This fixes an issue where dragging a Name block out of a Pitch block and then dragging it back in caused a redundant Name block to appear, instead of the original block snapping back without duplication.
What’s fixed
Prevented addDefaultBlock() from recreating Name sub-blocks while snapping back.
Name blocks now behave like Octave blocks— detach cleanly and snap back into place.
How to test
Create a Pitch Block
Drag the Name block out- a default duplicate must appear
Drop the Name block back - it should reattach without creating any redundant Name block
Screen.Recording.2025-11-08.at.12.32.54.AM.mov
Fixes #4794
Tested on macOS (Chrome) and verified consistent behavior with Name block logic.