feat: introduce DefaultExtensionCatalog.DEFAULT_COLLECTION#529
Merged
Conversation
Provide convenient static instance of default ExtensionCollection BREAKING CHANGE: removed SimpleExtension.loadDefaults
vbarua
commented
Oct 1, 2025
| public static final String FUNCTIONS_STRING = "/functions_string.yaml"; | ||
|
|
||
| public static final SimpleExtension.ExtensionCollection DEFAULT_COLLECTION = | ||
| loadDefaultCollection(); |
Member
Author
There was a problem hiding this comment.
We can load the default ExtensionCollection once, and then share it everywhere.
Member
Author
|
Looking through #522, I noticed that we were calling |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Provide convenient static instance of default ExtensionCollection
BREAKING CHANGE: removed SimpleExtension.loadDefaults