test(isthmus): round-trip testing of TPC queries#396
Merged
Conversation
Member
Author
|
Inspired by some of the additional testing in #383. |
vbarua
approved these changes
May 7, 2025
Member
vbarua
left a comment
vbarua
left a comment
There was a problem hiding this comment.
Changes look good overall. Just had one question around printing the plans and SQL strings.
| return Arrays.stream(values) | ||
| .filter(t -> !t.trim().isBlank()) | ||
| .collect(java.util.stream.Collectors.toList()); | ||
| /** Holder class to load TPC-H create statements only once on first access. */ |
In addition to the existing testing of conversion from TPC-H and TPC-DS SQL queries to Substrait, test conversion of the generated Substrait back to SQL. Signed-off-by: Mark S. Lewis <Mark.S.Lewis@outlook.com> Co-authored-by: MBWhite <whitemat@uk.ibm.com>
bestbeforetoday
force-pushed
the
tpc-roundtrip-tests
branch
from
c9e78e3 to
05a93b4
Compare
vbarua
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In addition to the existing testing of conversion from TPC-H and TPC-DS SQL queries to Substrait, test conversion of the generated Substrait back to SQL.