feat: add object shorthand property mutator#2175
Closed
brody2consult wants to merge 2 commits intostryker-mutator:masterfrom
Closed
feat: add object shorthand property mutator#2175brody2consult wants to merge 2 commits intostryker-mutator:masterfrom
brody2consult wants to merge 2 commits intostryker-mutator:masterfrom
Conversation
added 2 commits
May 3, 2020 23:30
to mutator-specification
5 tasks
Member
|
See #2172 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As I said before, I have been using Stryker pretty heavily and happily in my create-react-native-module utility. I have discovered a few cases over the past year where there were object properties that were simply not needed, sometimes because of functionality removed and sometimes for other reasons. Yes I am the one to be held responsible but think it should be possible for Stryker to help find cases like this.
In short, this is a proposal to try removing shorthand object properties, for example:
{ bar, baz: "quz" }-->{ baz: "quz" }Here are a couple of cleanup fixes that could have been discovered by using this proposal:
I made this proposal on the JavaScript mutator only, would be happy to take a look into the TypeScript version in case there is any interest. I do think it would be ideal to consider using @typescript/eslint-parser which should let us work with the TypeScript parser without having to maintain multiple implementations of the ES mutators.
TODO items updated:
P.S. I would highly recommend a squash commit merge in case this proposal is accepted.