Switch from local bootstrap and bootstrap-icons to their WebJars resources#363
Open
peutch wants to merge 3 commits intostruts-community-plugins:release/6.0.xfrom
Open
Switch from local bootstrap and bootstrap-icons to their WebJars resources#363peutch wants to merge 3 commits intostruts-community-plugins:release/6.0.xfrom
peutch wants to merge 3 commits intostruts-community-plugins:release/6.0.xfrom
Conversation
Member
|
but shouldn't we add support for WebJars into Struts itself? |
Contributor
Author
|
I think at least something could be done in the same way for struts2-jquery if there is interest in it. |
Member
|
I meant to add support for |
Contributor
Author
|
Could |
Contributor
|
The down side is it does make it more difficult to debug (ie adding console.log) as the assets are in a jar. Also don't want the pom versions managed by renovate bot. |
Member
It can be, but I would rather add a dedicated logic to serve WebJars, something like |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
Following my remark about the use of WebJars in issue #354, here is an attempt to migrate struts2-bootstrap as an illustration.
I think it could simplify upgrading the dependency to Bootstrap and Bootstrap Icons components.
Note that it also includes a small fix 4ca2fbf.
Regards,
Patrice