Implement complete pymcprotocol Type3E API compatibility#13
Draft
Implement complete pymcprotocol Type3E API compatibility#13
Conversation
Co-authored-by: strnh <874989+strnh@users.noreply.github.com>
Co-authored-by: strnh <874989+strnh@users.noreply.github.com>
…l client calls Co-authored-by: strnh <874989+strnh@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Complete pymcprotocol compatible API
Implement complete pymcprotocol Type3E API compatibility
Dec 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The wrapper provided only simplified abstractions (
read_data(),write_data(),disconnect()) instead of the full pymcprotocol Type3E API, limiting its utility as a proper wrapper library.Changes
API Implementation
ClientandMockClient:batchread_wordunits(),batchread_bitunits(),batchwrite_wordunits(),batchwrite_bitunits()randomread(),randomwrite(),randomwrite_bitunits()read_cputype(),echo_test(),setaccessopt()remote_run(),remote_stop(),remote_pause(),remote_reset(),remote_latchclear(),remote_unlock(),remote_lock()close()as pymcprotocol-compatible aliasImplementation Details
Clientdelegates to external pymcprotocol.Type3E when available, falls back to mock mode otherwiseread_data()/write_data()now usebatchread_wordunits()/batchwrite_wordunits()for external clientsTesting & Documentation
examples/pymcprotocol_compatible_usage.pyUsage
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
192.168.1.1/usr/bin/python3 python3 -m pytest tests/test_pymcprotocol_compat.py -v(packet block)/usr/bin/python3 python3 -m pytest tests/ -v(packet block)/usr/bin/python3 python3 -m pytest tests/ -v INVALID,NEW -j DROP(packet block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.