Update dependencies#23
Open
montdidier wants to merge 2 commits into
Open
Conversation
OutlawAndy
requested changes
Aug 17, 2017
OutlawAndy
left a comment
OutlawAndy
left a comment
Member
There was a problem hiding this comment.
Thank you for the pull request, looks great!
If you would please address the 2 inline comments I left, I'll get it merged.
…RSION over hardcoded string
Author
|
Sorry for the long absence. Changed as requested. |
Author
|
@OutlawAndy bump. Anything else you need for this? |
|
Nice goodjob |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #18