Skip to content

Fix endianness of delete on rewind table #1080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
quantumagi merged 4 commits into from
Oct 30, 2022
Merged

Fix endianness of delete on rewind table #1080

quantumagi merged 4 commits into from
Oct 30, 2022

Conversation

@quantumagi
Copy link
Contributor

@quantumagi quantumagi commented Oct 27, 2022 •
edited
Loading

This PR does the following:

  • Fixes the endianness of the key used for the delete operation on the rewind table.
  • Ensures that coin updates are visible in transaction context by using the new ReadWriteBatch (in CoinDb).
  • Source blocks from ConsensusManager instead of BlockStore to fully leverage caching.
  • Add ability to rebuild the CoinView directly from the blocks.
  • Update the AddressIndexer tests to support the rebuilding.
  • Refactor the BinarySearch performed by the CachedCoinView's Sync method.

This PR helps reduce the sizes of PR #1031 and PR #1053. It contains the changes not directly related to those PRs.

@quantumagi quantumagi requested a review from zeptin October 27, 2022 13:16
zeptin
zeptin reviewed Oct 29, 2022
View reviewed changes
zeptin
zeptin reviewed Oct 29, 2022
View reviewed changes
@quantumagi quantumagi merged commit 81d3ad7 into stratisproject:release/1.5.0.0 Oct 30, 2022
quantumagi added a commit to quantumagi/StratisFullNode-1 that referenced this pull request Jan 31, 2023
@quantumagi
Fix endianness of delete on rewind table (stratisproject#1080)
4170264 
* Fix endianness of delete on rewind table

* Fix duplicate call

* Fix consistency

* Update mock

(cherry picked from commit 81d3ad7)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zeptin zeptin zeptin approved these changes

Assignees

No one assigned

Labels

1.6.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@quantumagi @zeptin