Make method classes #1261
Draft
Make method classes #1261
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: mulhern <amulhern@redhat.com>
mulkieran
force-pushed
the
make-method-classes
branch
from
623652d to
820d4d9
Compare
Make static generator classes for each interface and use them to generate the auto-classes. Do not require that the methods that are decorated to require absolute paths be actually present in the generated class, although they will be. This allows skipping one try/except block and will be robust in case future implementations also allow generating the methods lazily. Signed-off-by: mulhern <amulhern@redhat.com>
mulkieran
force-pushed
the
make-method-classes
branch
2 times, most recently
from
b7ea4d1 to
c8fc2e4
Compare
It's no longer necessary to import the classes in _data outside the top level. Import them in the usual way and remove the assertion about not importing _data at the same time as any other module is imported. Signed-off-by: mulhern <amulhern@redhat.com>
mulkieran
force-pushed
the
make-method-classes
branch
from
c8fc2e4 to
dee67eb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.