Skip to content

BUG: Fix handling empty migration list for VMs#464

Merged
azahmd merged 1 commit into
mainfrom
Fix_empty_migration_iter
Jul 2, 2026
Merged

BUG: Fix handling empty migration list for VMs#464
azahmd merged 1 commit into
mainfrom
Fix_empty_migration_iter

Conversation

@DavidFair

@DavidFair DavidFair commented Jul 1, 2026

Copy link
Copy Markdown
Collaborator

Description:

If a VM had an empty migration list we would die if we asked nova faster than the migration turned up. Instead handle this case and use the existing wait for migration code to retry

Special Notes:

Submitter:

Have you (where applicable):

  • Added unit tests?
  • Checked the latest commit runs on Dev?
  • Updated the example config file(s) and README?

Reviewer

Does this PR:

  • Place non-StackStorm code into the lib directory?
  • Have unit tests for the action/sensor and lib layers?
  • Have clear and obvious action parameter names and descriptions?

@DavidFair DavidFair added the bug Something isn't working label Jul 1, 2026
@DavidFair DavidFair force-pushed the Fix_empty_migration_iter branch 2 times, most recently from 1274f90 to aac78e7 Compare July 1, 2026 14:24
@codecov

codecov Bot commented Jul 1, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.19%. Comparing base (bdf2fa7) to head (c678935).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #464   +/-   ##
=======================================
  Coverage   99.19%   99.19%           
=======================================
  Files         112      112           
  Lines        2737     2742    +5     
  Branches      339      339           
=======================================
+ Hits         2715     2720    +5     
  Misses         19       19           
  Partials        3        3           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

If a VM had an empty migration list we would die if we asked nova faster
than the migration turned up. Instead handle this case and use the existing
wait for migration code to retry
@DavidFair DavidFair force-pushed the Fix_empty_migration_iter branch from aac78e7 to c678935 Compare July 1, 2026 14:32
@DavidFair

Copy link
Copy Markdown
Collaborator Author

Testing on dev with a fresh VM:

    2026-07-01 14:49:38,805 - apis.openstack_api.openstack_server - INFO - Migrating server: dfc7ba5a-e8a8-4fc3-a3f3-4e0fbc277138
    2026-07-01 14:49:39,442 - apis.openstack_api.openstack_server - INFO - No migration details available for dfc7ba5a-e8a8-4fc3-a3f3-4e0fbc277138 yet
    2026-07-01 14:49:44,469 - apis.openstack_api.openstack_server - INFO - Status of migration of server dfc7ba5a-e8a8-4fc3-a3f3-4e0fbc277138: migrating
    2026-07-01 14:49:49,491 - apis.openstack_api.openstack_server - INFO - Status of migration of server dfc7ba5a-e8a8-4fc3-a3f3-4e0fbc277138: migrating
    2026-07-01 14:49:54,515 - apis.openstack_api.openstack_server - INFO - Status of migration of server dfc7ba5a-e8a8-4fc3-a3f3-4e0fbc277138: post-migrating
    2026-07-01 14:49:59,543 - apis.openstack_api.openstack_server - INFO - Status of migration of server dfc7ba5a-e8a8-4fc3-a3f3-4e0fbc277138: post-migrating
    2026-07-01 14:50:04,570 - apis.openstack_api.openstack_server - INFO - Status of migration of server dfc7ba5a-e8a8-4fc3-a3f3-4e0fbc277138: post-migrating
    2026-07-01 14:50:09,594 - apis.openstack_api.openstack_server - INFO - Status of migration of server dfc7ba5a-e8a8-4fc3-a3f3-4e0fbc277138: post-migrating
    2026-07-01 14:50:14,617 - apis.openstack_api.openstack_server - INFO - Status of migration of server dfc7ba5a-e8a8-4fc3-a3f3-4e0fbc277138: finished
    2026-07-01 14:50:14,693 - apis.openstack_api.openstack_server - INFO - Confirming resize for dfc7ba5a-e8a8-4fc3-a3f3-4e0fbc277138
    2026-07-01 14:50:14,740 - apis.openstack_api.openstack_server - INFO - Migration completed of server: dfc7ba5a-e8a8-4fc3-a3f3-4e0fbc277138
    '
  stdout: ''

@azahmd azahmd merged commit 9ffd0b1 into main Jul 2, 2026
14 checks passed
@azahmd azahmd deleted the Fix_empty_migration_iter branch July 2, 2026 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants