BUG: Fix handling empty migration list for VMs#464
Merged
Conversation
1274f90 to
aac78e7
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #464 +/- ##
=======================================
Coverage 99.19% 99.19%
=======================================
Files 112 112
Lines 2737 2742 +5
Branches 339 339
=======================================
+ Hits 2715 2720 +5
Misses 19 19
Partials 3 3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
If a VM had an empty migration list we would die if we asked nova faster than the migration turned up. Instead handle this case and use the existing wait for migration code to retry
aac78e7 to
c678935
Compare
Collaborator
Author
|
Testing on dev with a fresh VM: |
jose-caballero
approved these changes
Jul 2, 2026
azahmd
approved these changes
Jul 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
If a VM had an empty migration list we would die if we asked nova faster than the migration turned up. Instead handle this case and use the existing wait for migration code to retry
Special Notes:
Submitter:
Have you (where applicable):
Reviewer
Does this PR:
libdirectory?liblayers?