BUG: Skip any migration or snapshot steps if we're in an invalid state#461
Merged
jose-caballero merged 1 commit intoJul 1, 2026
Merged
Conversation
Skips any migration steps, as we would previously take a snapshot - force the user to wait for multiple hours then fail when we knew up-front it wouldn't work. Instead provide rapid feedback that we can't do an error state or we can't migrate before doing any work
506e787 to
eeaf104
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## add_flag_live_migration #461 +/- ##
========================================================
Coverage 99.19% 99.19%
========================================================
Files 112 112
Lines 2737 2739 +2
Branches 339 340 +1
========================================================
+ Hits 2715 2717 +2
Misses 19 19
Partials 3 3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
jose-caballero
approved these changes
Jul 1, 2026
Collaborator
Author
|
Now correctly skips all steps if we attempt to do it with an error: |
This was referenced Jul 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Skips any migration steps, as we would previously take a snapshot - force the user to wait for multiple hours then fail when we knew up-front it wouldn't work.
Instead provide rapid feedback that we can't do an error state or we can't migrate before doing any work
TODO: test this works on dev once #459 is merged
Special Notes:
Submitter:
Have you (where applicable):
Reviewer
Does this PR:
libdirectory?liblayers?