Skip to content

Remove image timeout#460

Draft
DavidFair wants to merge 2 commits into
mainfrom
Rework_manual_wait_snapshots
Draft

Remove image timeout#460
DavidFair wants to merge 2 commits into
mainfrom
Rework_manual_wait_snapshots

Conversation

@DavidFair

Copy link
Copy Markdown
Collaborator

Description:

Removes manually handling image timeouts - the wait flag should imply this and it's brittle for other unit tests where this can hang

Unfortunately, we can't do the same for migrate, as there's no equivalent flag

Special Notes:


Submitter:

Have you (where applicable):

  • Added unit tests?
  • Checked the latest commit runs on Dev?
  • Updated the example config file(s) and README?

Reviewer

Does this PR:

  • Place non-StackStorm code into the lib directory?
  • Have unit tests for the action/sensor and lib layers?
  • Have clear and obvious action parameter names and descriptions?

Removes manually handling image timeouts - the wait flag should imply this and it's brittle for other unit tests where this can hang
Unfortunately, we can't do the same for migrate, as there's no equivalent flag
@DavidFair DavidFair force-pushed the Rework_manual_wait_snapshots branch from 515195b to 113f21f Compare June 29, 2026 13:46
@codecov

codecov Bot commented Jun 29, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.18%. Comparing base (509c54b) to head (ca7589b).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #460      +/-   ##
==========================================
- Coverage   99.19%   99.18%   -0.01%     
==========================================
  Files         112      112              
  Lines        2726     2715      -11     
  Branches      338      335       -3     
==========================================
- Hits         2704     2693      -11     
  Misses         19       19              
  Partials        3        3              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Adds a ST2 action to expose existing functionality to snapshot a server. This also allows us to test any changes to
snapshots in isolation too.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant