Remove image timeout#460
Draft
DavidFair wants to merge 2 commits into
Draft
Conversation
Removes manually handling image timeouts - the wait flag should imply this and it's brittle for other unit tests where this can hang Unfortunately, we can't do the same for migrate, as there's no equivalent flag
515195b to
113f21f
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #460 +/- ##
==========================================
- Coverage 99.19% 99.18% -0.01%
==========================================
Files 112 112
Lines 2726 2715 -11
Branches 338 335 -3
==========================================
- Hits 2704 2693 -11
Misses 19 19
Partials 3 3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Adds a ST2 action to expose existing functionality to snapshot a server. This also allows us to test any changes to snapshots in isolation too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Removes manually handling image timeouts - the
waitflag should imply this and it's brittle for other unit tests where this can hangUnfortunately, we can't do the same for migrate, as there's no equivalent flag
Special Notes:
Submitter:
Have you (where applicable):
Reviewer
Does this PR:
libdirectory?liblayers?