Skip to content

(Towards #2381) Re-structure classes for reduction nodes.#3333

Open
arporter wants to merge 25 commits intomasterfrom
2381_gredns_feb26
Open

(Towards #2381) Re-structure classes for reduction nodes.#3333
arporter wants to merge 25 commits intomasterfrom
2381_gredns_feb26

Conversation

@arporter
Copy link
Member

No description provided.

@arporter arporter marked this pull request as draft February 16, 2026 15:53
@arporter arporter self-assigned this Feb 16, 2026
@codecov
Copy link

codecov bot commented Feb 17, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.95%. Comparing base (8ecb098) to head (2730335).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3333      +/-   ##
==========================================
- Coverage   99.95%   99.95%   -0.01%     
==========================================
  Files         382      384       +2     
  Lines       54094    54009      -85     
==========================================
- Hits        54072    53987      -85     
  Misses         22       22              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@arporter arporter added enhancement LFRic PSyKAl-lite Issue related to removal of PSyKAl-lite code in LFRic labels Feb 18, 2026
@arporter arporter moved this from Todo to In Progress in LFRic 25/26 Feb 18, 2026
@arporter arporter deployed to integration February 18, 2026 21:56 — with GitHub Actions Active
@arporter arporter requested review from hiker and sergisiso February 19, 2026 09:00
@arporter arporter marked this pull request as ready for review February 19, 2026 09:00
@arporter
Copy link
Member Author

ITs were green. This is ready for a first look from either @hiker, @sergisiso or @LonelyCat124. There's a fair bit of code movement as I've taken code out of the monoliths that are lfric.py and psyGen.py and put it into separate modules. I've done the same thing for the tests. Essentially though, it just restructures the class hierarchy and introduces LFRicGlobal{Max,Min,Sum}.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement LFRic PSyKAl-lite Issue related to removal of PSyKAl-lite code in LFRic ready for review

Projects

Status: In Progress

Development

Successfully merging this pull request may close these issues.

1 participant

Comments