Skip to content

Serve app as a web app and provide a max tokens option within sampling #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
ichim-david wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Serve app as a web app and provide a max tokens option within sampling #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cdef2a8
Introduced max-tokens as default value sometimes gave truncated repli…
ichim-david May 2, 2026
471dc56
feat: add web app server + HTTP API client
tiberiuichim May 3, 2026
61f04cd
Add webport plan
tiberiuichim May 3, 2026
dd46e4a
refactor: reorganize app metadata loading and path resolution
ichim-david May 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion BENCH_PACK_AUTHORING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,7 +185,7 @@ Behavior:

- if a Bench Pack provides a default, BenchLocal uses it unless the user overrides it in that tab
- if a field is omitted, BenchLocal falls back to platform defaults where defined
- BenchLocal currently applies `request_timeout_seconds: 300` unless your pack or the user overrides it
- BenchLocal currently applies `max_tokens: 2048` and `request_timeout_seconds: 300` unless your pack or the user overrides them

## Compatibility requirements

Expand Down
3 changes: 2 additions & 1 deletion BENCH_PROTOCOL_V1.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,6 +205,7 @@ type GenerationRequest = {
top_k?: number;
min_p?: number;
repetition_penalty?: number;
max_tokens?: number;
request_timeout_seconds?: number;
};
```
Expand All @@ -213,7 +214,7 @@ Behavior:

- if a field is present, the pack may forward it to the provider client
- if a field is omitted, BenchLocal may still supply a platform default before the pack receives the request
- BenchLocal currently applies `request_timeout_seconds: 300` unless the pack or user overrides it
- BenchLocal currently applies `max_tokens: 2048` and `request_timeout_seconds: 300` unless the pack or user overrides them

This allows:

Expand Down
15 changes: 14 additions & 1 deletion app/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,11 +20,21 @@
"build:mac": "npm run build:compile && npm run package:mac",
"build:win": "npm run build:compile && npm run package:win",
"build:linux": "npm run build:compile && npm run package:linux",
"typecheck": "tsc -p tsconfig.json --noEmit"
"typecheck": "tsc -p tsconfig.json --noEmit",
"web:dev:renderer": "vite --config vite.config.web.ts",
"web:dev:server": "tsx watch src/server/index.ts",
"web:dev": "concurrently \"npm run web:dev:renderer\" \"npm run web:dev:server\"",
"web:build": "npm run build:compile && vite build --config vite.config.web.ts && esbuild src/server/index.ts --bundle --platform=node --target=node20 --format=esm --packages=external --outfile=../dist/server/index.mjs --external:@benchlocal/*",
"preweb:start": "npm run web:build",
"web:start": "node ../dist/server/index.mjs"
},
"dependencies": {
"electron-updater": "^6.6.2",
"lucide-react": "^1.7.0",
"@benchlocal/benchpack-host": "file:../packages/benchpack-host",
"@benchlocal/core": "file:../packages/benchlocal-core",
"@fastify/static": "^8.0.0",
"fastify": "^5.0.0",
"react": "^19.0.0",
"react-dom": "^19.0.0"
},
Expand All @@ -41,6 +51,9 @@
"postcss": "^8.5.1",
"tailwindcss": "^4.1.11",
"typescript": "^5.8.3",
"concurrently": "^9.0.0",
"esbuild": "^0.25.0",
"tsx": "^4.0.0",
"vite": "^6.3.5"
},
"build": {
Expand Down
Loading